Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring Python code into compliance with Black and Flake8 #121

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Bring Python code into compliance with Black and Flake8 #121

merged 4 commits into from
Apr 17, 2020

Commits on Apr 17, 2020

  1. Ignore Flake8 unused import error F401 

    https://flake8.readthedocs.io/en/latest/user/error-codes.html

The apparently unused imports may be needed for SQLAlchemy.

As the code comment says:

make sure all SQL Alchemy models are imported before initializing DB
otherwise, SQL Alchemy might fail to initialize properly relationships

See GitHub 28 and 29
    @br3ndonland @tiangolo
    br3ndonland authored and tiangolo committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    93a061b View commit details
    Browse the repository at this point in the history

  2. Ignore Flake8 unused variable error F841 

    https://flake8.readthedocs.io/en/latest/user/error-codes.html

The apparently unused variables may be needed for tests.
    @br3ndonland @tiangolo
    br3ndonland authored and tiangolo committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    299512c View commit details
    Browse the repository at this point in the history

  3. Bring line length into compliance with Black 

    Should be 88 characters.
    @br3ndonland @tiangolo
    br3ndonland authored and tiangolo committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    32263f9 View commit details
    Browse the repository at this point in the history

  4. Format alembic code with Black

    @br3ndonland @tiangolo
    br3ndonland authored and tiangolo committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    6aab25a View commit details
    Browse the repository at this point in the history