-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fix docs light/dark theme switcher #1
Conversation
Oh I see that https://fastapi.tiangolo.com/ uses the same tooltips. Should I create a PR there too, or is this intentional and not a mistake? |
Looks similar if not the same? fastapi/fastapi#3246 |
Maybe swapping the icons would be better too, sure. While using the light theme the bulb would be "turned on" and with the dark theme it would be "off". Makes sense to me. However fastapi/fastapi#3246 does not fix the tooltip texts. |
Anyway, swapping the text alone seems like an improvement for me. Swapping the icons can be something for another PR. |
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 97.27%
=======================================
Files ? 175
Lines ? 5842
Branches ? 0
=======================================
Hits ? 5683
Misses ? 159
Partials ? 0 Continue to review full report at Codecov.
|
Great, thank you @Lehoczky! 🚀 And thanks for the comments @ArcLightSlavik! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1 fix
Just a simple fix for the lightbulb's tooltip on the documentation site:
Before:
After: