Skip to content

Conversation

scku208
Copy link

@scku208 scku208 commented Aug 13, 2024

For users new to SQLModel, the documentation might be confusing. It is recommended to focus on explanations for Python 3.10+ or to include additional parenthetical notes explaining differences from earlier versions.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Aug 13, 2024
Copy link
Contributor

@scku208
Copy link
Author

scku208 commented Aug 13, 2024

I apologize, but the final reference to Optional[Team] in that particular paragraph should also be updated to Team | None. (also, Optional[int] should be updated to int | None)

@alejsdev alejsdev changed the title Update define relationships attributes docs: Optional[Team] -> Team | None 📝 Update define relationships attributes docs: Optional[Team] -> Team | None Aug 22, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

@svlandeg svlandeg marked this pull request as draft February 24, 2025 10:40
@iloveitaly
Copy link

I apologize, but the final reference to Optional[Team] in that particular paragraph should also be updated to Team | None. (also, Optional[int] should be updated to int | None)

@scku208 could you update the PR with this change so we can get this ready to be merged?

@tiangolo
Copy link
Member

Thanks! This was covered in #1351, so I'll close this one now. 🤓 ☕

@tiangolo tiangolo closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants