-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade SQLAlchemy to 2.0, including initial work by farahats9 #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stefan Borer <stefan.borer@gmail.com>
Fix most linting errors
…pes, now beautifully defined in SQLAlchemy
…pport of forward references in relationships
📝 Docs preview for commit 80a5c52 at: https://77c66c1a.sqlmodel.pages.dev |
📝 Docs preview for commit 40beca9 at: https://b1ab6983.sqlmodel.pages.dev |
📝 Docs preview for commit be5277e at: https://0db51043.sqlmodel.pages.dev |
tiangolo
changed the title
✨ Upgrade SQLAlchemy to 2.0, including initial work by @farahats9
✨ Upgrade SQLAlchemy to 2.0, including initial work by farahats9
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Upgrade SQLAlchemy to 2.0, including initial work by @farahats9
This includes @farahats9 commits from #563 and builds on top.
select().where()
.or_(Hero.name == "Deadpond")
as SQLAlchemy's version would requireHero.name
to be aMapped[str]
instead of astr
.Mapped[X]
, but sadly that breaks type annotations for creating new instances and dataclass_transform, as then that would expect to receive values withMapped[X]
, e.g.Mapped[str]
instead ofstr
. And it would also add complications to the Pydantic handling. So, this was a lot of work mostly exploratory, but not much ended in the PR.