-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Fix minor inconsistencies and typos in tutorial #1067
Conversation
📝 Docs preview for commit 96ee5ce at: https://c6810e60.typertiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All three are a nice catch, thanks! Looks good to merge.
📝 Docs preview for commit 6f06c9e at: https://25632f27.typertiangolo.pages.dev Modified Pages |
Thanks for your feedback. Oops sorry, I realize I had not updated the python files associated with the code block impacted by my update in (I had not thoroughly read and applied the contributing guide that describes this link between docs and python files/tests. That should teach me!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! 🚀 🔍
I think I saw a couple of typos or inconsistencies in the tutorial:
commands/one-or-multiple.md
command/options.md
first-steps.md
(I doubt a typer "parameter" or "argument" refers to a python function)Thanks a lot for your work on this great tool. I hope this helps!