Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Update link in docs to the newest stable version of click #675

Merged
merged 1 commit into from
Mar 23, 2024
Merged

📝 Update link in docs to the newest stable version of click #675

merged 1 commit into from
Mar 23, 2024

Conversation

javier171188
Copy link
Contributor

@javier171188 javier171188 commented Oct 1, 2023 •
edited
Loading

Updated a link to the newest stable version of click

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

📝 Docs preview for commit 3ecb83d at: https://069ee31d.typertiangolo.pages.dev

JacobKochems
JacobKochems approved these changes Nov 16, 2023
View reviewed changes
Copy link

@JacobKochems JacobKochems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link indeed points to the latest stable version. No code changed.
I approve this.

@svlandeg svlandeg added docs Improvements or additions to documentation p3 labels Feb 29, 2024
svlandeg
svlandeg approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click is currently pinned at >= 7.1.1, <9.0.0 so it makes sense to me to update the reference to their docs to 8.1.x instead of 7.x.

Thanks!

@svlandeg svlandeg added the click Related to Click functionality label Mar 8, 2024
@tiangolo tiangolo changed the title Updated a link to the newest stable version of click 📝 Update link in docs to the newest stable version of click Mar 23, 2024
@tiangolo tiangolo merged commit 5bb6b3a into fastapi:master Mar 23, 2024
18 checks passed
@tiangolo
Copy link
Member

NIce, thanks @javier171188! 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobKochems JacobKochems JacobKochems approved these changes

@peidrao peidrao peidrao approved these changes

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
click Related to Click functionality docs Improvements or additions to documentation p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javier171188 @tiangolo @svlandeg @peidrao @JacobKochems