Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile stage for JAR assembly #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marcomicera
Copy link
Member

I was working on https://github.com/fasten-project/k8s-deployments/issues/22 and I might have to edit the base image of this sync job.

I added a target package which runs sbt assembly in a Dockerfile stage, as I don't want to install sbt on my local machine. With .dockerignore, one can leverage the Docker build cache more efficiently as COPY . . only copies the necessary files. The package-ci target makes it work in CI.

I've tested this already.

@marcomicera marcomicera added the enhancement New feature or request label Aug 13, 2021
@marcomicera marcomicera self-assigned this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant