Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FhirPatient test to validate identifier and telecom for example1 #287

Merged

Conversation

akash-pandey1729
Copy link
Contributor

@akash-pandey1729 akash-pandey1729 commented Oct 21, 2023

Added unit test to validate the SearchExtractParameters for identifier and telecom attributes of the patient model using example 1 as input data.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2023

CLA assistant check
All committers have signed the CLA.

@akash-pandey1729 akash-pandey1729 changed the title unit test for identifier and telecom for example1 unit test for identifier and telecom for ExtractSerarchParamaters for example1 Oct 21, 2023
@AnalogJ
Copy link
Member

AnalogJ commented Oct 21, 2023

Fantastic work @akash-pandey1729 this is exactly what I was looking for! Thanks for the PR!

One last nit I would change the title of your PR

  • from - unit test for identifier and telecom for ExtractSerarchParamaters for example1
  • to - update FhirPatient test to validate identifier and telecom

Basically just a quick summary of the Resource that we've added tests for, and what fields we've validated. Specifying the ExtractSerarchParamaters function is unecessary because thats the only real function in every struct

@AnalogJ
Copy link
Member

AnalogJ commented Oct 21, 2023

Once you're done making changes just ping me and I'll merge this 🎉 !

@akash-pandey1729 akash-pandey1729 changed the title unit test for identifier and telecom for ExtractSerarchParamaters for example1 update FhirPatient test to validate identifier and telecom for example1 Oct 21, 2023
@AnalogJ
Copy link
Member

AnalogJ commented Oct 21, 2023

that was fast! looking good :) Once the CI passes, I'll merge it!

@AnalogJ AnalogJ merged commit 8f430f4 into fastenhealth:main Oct 21, 2023
3 of 5 checks passed
@AnalogJ
Copy link
Member

AnalogJ commented Oct 21, 2023

thanks for the PR @akash-pandey1729 !

@AnalogJ AnalogJ mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants