Support for rules_oci 2.x (using bzlmod) #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered two issues when upgrading to
rules_oci
2.x. The same issues were also raised on Bazel Slack here.@rules_oci//oci:repositories.bzl
no longer exports aLATEST_CRANE_VERSION
variable. I refactoredrepositories.bzl
and extracted toolchain-related stuff used by the bzlmod extension to a newtoolchains.bzl
.repositories.bzl
still requiresLATEST_CRANE_VERSION
, but it's no longer loaded by the bzlmod extension, so doesn't cause failures.oci_push
no longer depends on theyq
toolchain. I've updatedpush_oci_rule
to explicitly depend on theyq
toolchain in addition to whatever else the underlyingoci_push
implementation depends on.