Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rules_oci 2.x (using bzlmod) #40

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jvolkman
Copy link
Contributor

I encountered two issues when upgrading to rules_oci 2.x. The same issues were also raised on Bazel Slack here.

  1. @rules_oci//oci:repositories.bzl no longer exports a LATEST_CRANE_VERSION variable. I refactored repositories.bzl and extracted toolchain-related stuff used by the bzlmod extension to a new toolchains.bzl. repositories.bzl still requires LATEST_CRANE_VERSION, but it's no longer loaded by the bzlmod extension, so doesn't cause failures.
  2. oci_push no longer depends on the yq toolchain. I've updated push_oci_rule to explicitly depend on the yq toolchain in addition to whatever else the underlying oci_push implementation depends on.

@apesternikov apesternikov self-requested a review July 16, 2024 17:58
Copy link
Contributor

@apesternikov apesternikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I will make another pass to replace yq dependency with jq in a separate PR.

@apesternikov apesternikov merged commit d49f3cb into fasterci:main Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants