Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build failed in old MacOS (10.13 High Sierra) since fastfetch 2.21.2 #1190

Closed
niu541412 opened this issue Aug 15, 2024 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@niu541412
Copy link
Contributor

Be sure to read the FAQ before submitting a new issue.

General description of bug:

  • What happened:
    The following is the build log:
...
[ 77%] Building C object CMakeFiles/libfastfetch.dir/src/detection/displayserver/displayserver_apple.c.o
/Users/username/Downloads/fastfetch/src/detection/displayserver/displayserver_apple.c:92:21: error: use of undeclared identifier 'CoreDisplay_Display_IsHDRModeEnabled'
                if (CoreDisplay_Display_IsHDRModeEnabled)
/Users/username/Downloads/fastfetch/src/detection/displayserver/displayserver_apple.c:94:43: error: implicit declaration of function 'CoreDisplay_Display_IsHDRModeEnabled' is
      invalid in C99 [-Werror,-Wimplicit-function-declaration]
                    display->hdrEnabled = CoreDisplay_Display_IsHDRModeEnabled(screen);
...

This error is intruduced from the commit ea18d93, because CoreDisplay_Display_IsHDRModeEnabled
is called in all MacOS version, but it's only provided since MacOS 10.15. It can be fixed with macro condition statement or Null pointer checking of CoreDisplay_Display_IsHDRModeEnabled.

@niu541412 niu541412 added the bug Something isn't working label Aug 15, 2024
CarterLi added a commit to CarterLi/fastfetch that referenced this issue Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant