LocalIp: support get interface flags #1315
Conversation
|
Spellcheck's error is a noise. This is just a flag name, we can do nothing about it. |
| { | ||
| .flag = IFF_UP, | ||
| .name = "UP", | ||
| }, |
There was a problem hiding this comment.
I prefer { IFF_UP, "UP" } so that they take less spaces.
| { | ||
| if (ioctl(sockfd, SIOCGIFFLAGS, &ifr) == 0) | ||
| writeNIFlagsToStrBuf(&iface->flags, ifr.ifr_flags, nicFlags); | ||
| } |
There was a problem hiding this comment.
getifaddrs will return all interfaces in the local system which we already got. It might be heavier than creating a socket then calling a ioctl.
And manpages say this function is not a part of the standard, it could be different on other systems.
So, I think using ioctl and ifreq here may be enough.
There was a problem hiding this comment.
But we have already called getifaddrs. Why not reuse its result?
There was a problem hiding this comment.
Oh, getifaddrs already called.
There was a problem hiding this comment.
Thanks for this advice, I'll change to reuse its result.
You should add it to |
apocelipes
force-pushed
the
feat/nic-flags
branch
from
6eb7ad1
to
d6c8bd7
Compare
Done. |
apocelipes
force-pushed
the
feat/nic-flags
branch
from
d6c8bd7
to
e27e910
Compare
Each net interface has its flags. These flags show the interface and its IP's status/capabilities.
Flags have already been reported by 'ifconfig' and 'ip addr' commands:
Add the same capability to fastfetch:
I also added a new option '--localip-show-flags' to control whether getting interface flags (the default value is FALSE).