Skip to content

Conversation

jinwk00
Copy link

@jinwk00 jinwk00 commented Oct 13, 2021

I updated Fedora logo to match the one for Fedora 34.

@LinusDierheimer
Copy link
Collaborator

I very appreciate this pull request. However i think the should keep the old logo as fedora_old (name the method initLogoFedoraOld).

Optional:

If you're into c, you can change loadLogoSet to load both logos.

If you have a lot of free time, ffLoadLogo has a FFOSResult. It has a field versionID, which tells us the version of the distribution. Would be great if fastfetch loads the correct logo for fedora depending on it. I think best practice for it would be to create a static method loadLogoSetVersion(FFinstance* instance, const FFOSResult* os, const char* logo), which is called by ffLoadLogo and calls loadLogoSet itself.

@LinusDierheimer
Copy link
Collaborator

You are still doing it? Otherwise i implement it using the new logo you provided.

@LinusDierheimer
Copy link
Collaborator

This is implemented.

@doldor doldor mentioned this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants