Skip to content

Conversation

CarterLi
Copy link
Member

@CarterLi CarterLi commented Oct 17, 2021

Main logic was used from https://stackoverflow.com/questions/212528/get-the-ip-address-of-the-machine

Screenshot with #91 and patch in #83 applied

image

Copy link
Collaborator

@LinusDierheimer LinusDierheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty solid already, few things keeping me from merging.

What do you think about creating separate modules for IPV4, IPV6, etc? Would give better customization possibility, as a separate key / format string could be provided for each. For common code you could provide a helper function in src/common, similar to plasma for example.

@CarterLi
Copy link
Member Author

Pretty solid already, few things keeping me from merging.

What do you think about creating separate modules for IPV4, IPV6, etc? Would give better customization possibility, as a separate key / format string could be provided for each. For common code you could provide a helper function in src/common, similar to plasma for example.

To be honest I don't think anyone is interested in local IP of IPV6 ( but public IP ). Making a separate IPV6 module seems to be redundant

@CarterLi
Copy link
Member Author

Resolved

@LinusDierheimer LinusDierheimer merged commit d288a69 into fastfetch-cli:master Oct 17, 2021
@LinusDierheimer
Copy link
Collaborator

Remember you can permanently set a structure / other options in ~/.config/fastfetch/config.conf

@CarterLi CarterLi deleted the localip branch October 20, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants