Disallow empty exponent in JSON parsing #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON spec requires at least one digit in the exponential part, if specified.
|
Running tests |
|
The GCC 13 CI error appears unrelated. |
|
I am going to merge this and release a patch. The fix seems obviously needed. There is a problem with GCC 13 in CI, but I will fix it separately before releasing. |
|
So giving this a second thought, I'm not sure it's correct -- fast_float is tolerant of junk after the number, and for |
LeszekSwirski
added a commit
that referenced
this pull request
Jul 23, 2024
Revert #251, and instead allow an invalid trailing empty exponent to be treated as junk data in JSON parsing. Expand the test suite to test this case, including testing the trailing junk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON spec requires at least one digit in the exponential part, if
specified.