-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual license the source code under MIT/APACHE #70
Conversation
I transfer any rights of my tiny change over to @lemire, you can remove me from the list. |
I do not think anyone could object to this change, and I am happy to merge. Because we are not a formal organization, the reasonable approach is just to wait some time, to give people a chance to object if they'd like, and then merge. I would point out that, as far as I can see, there is really no reason for the Rust version to have the same license as the C++ version. I'd like to remind us that there is no copyright on ideas, coding patterns, algorithms or mathematical results. And the Rust code is distinctly different. |
I transfer any rights of my tiny change over to @lemire, you can remove me from the list too |
me too (transferring any right to @lemire) |
I transfer any rights of my tiny change over to @lemire. |
The test failure is bogus, evidently, see #71 |
This change is done for two reasons: - First, the Rust port is, as of the time of writing in an awkward position because he is dual license under MIT/APACHE instead of only the APACHE license. This change in license should fix this problem. - Second, and the most convincing reason is that there have been some discussion with the Rust Libs Team to integrate the Rust port directly into the Rust standard library. The license change is required because the code for every the Rust repository need's to dual license against MIT/APACHE.
+1 I have rebase against main, updated a little bit the commit message and force force (squash). Now the workflows should all be green. |
@lemire Yes I agree but the issue is not on copyright but on the license of the source code. This repository use the Apache 2 license, this license defined what the license call "Derived Works", this include translations (both to a different natural language and to a different programming language), but it is not entirely clear how (and if any of) the requirements from the Apache license should be applied when the "Derived Works" is so radically different from the original source. However what is clear is that under the clause 4.c and 4 (end):
Every "Derivative Works" must also be license under the Apache 2 license and that re-licensing can be done but only if the license "complies with the conditions stated in this License" which is not the case for the MIT license. Given everything else and the fact that the code for the Rust repository is dual license against MIT/APACHE, I think that the Rust peoples might be a little be conservative about what falls under "Derived Works". In conclusion, dual licensing this source code prevents potential licensing issues with the Rust port and permit the integration of it in the Rust standard library. Source: License terms when porting free software to another language PS: I may be completly wrong, in that case do not hesitate to contradict my words. |
No objection from me |
We are just missing @biojppm. I am sure he will agree, it is simply a matter of getting him to notice us. |
@Urgau It seems that you are right, legally speaking. Maybe I should start defaulting on the MIT license then? |
You mean only on MIT ? Because with this pull request the code will be under the MIT and APACHE licenses at the option of the one how use it. But I would suggest to keep MIT/APACHE for "patent" issue. Josh Triplett said:
|
@Urgau I was thinking about new (future) projects. Ok. MIT + Apache could be a good default in the future. |
Oh, sorry for misinterpreted your question. In that case, yes MIT + Apache should be a pretty good default for your (and probably most peoples) future projects. |
Sorry for the delay. Indeed I do agree. |
Thank you very much! @lemire @Urgau (For this project, we really appreciate you being willing to match the license of Rust, to simplify integration of the derived Rust version. Thank you!) |
Looks good. |
Hello, I want this change to be done for two reasons:
because he is dual license under MIT/APACHE instead of only the
APACHE license. This change in license should fix this problem.
that some discussion as taken place with the Rust Libs Team
to integrate the Rust port directly into the Rust standard library.
And for that to happend the change in license is required because
the code for the Rust repository is dual license against MIT/APACHE.
Peoples who needs to agree to this change (based on code change only):
@eugenegff@kitaisreal@wojdyr@timkpaine