Allow users to opt out of literal comma "," query parameters parsing #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multi-value query params with api gateway v2.0 format, fixes fastify#202
|
Can you extend the readme accordingly? |
|
Updated the readme, thanks ! |
|
included in v4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202 by adding a new optional option
parseCommaSeparatedQueryParamsto opt-out from parsing multi-value query params with api gateway v2.0 format.Additionally fixes a bug where the lambda incoming
eventargument was manipulated during the parsing. This may cause confusion for users attempting to log the original lambda argument when usingrequest.awsLambda.event.queryStringParametersChecklist
npm run testandnpm run benchmarkand the Code of conduct