Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: allow users to run benchmarks non-interactively #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmarchini
Copy link
Contributor

This allows users to run benchmarks non-interactively by using command
line flags. Useful when running benchmarks automatically on CI
environments, for example.


Kind of an alternative to 9dc8d90#diff-6f09bc424586c395b13fd6f33fc863bcR8-R69 using commander to handle CLI parameters. I only saw that PR after I made this commit, thought I'd share anyway in case you want to go with this approach instead.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

This allows users to run benchmarks non-interactively by using command
line flags. Useful when running benchmarks automatically on CI
environments, for example.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

Would you mind to rebase/update this? I think #106 made some of these already.

@mmarchini
Copy link
Contributor Author

Will do when I'm back from vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants