-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf parse params decode text #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the work of mscdex regarding the decodeText. Pretty smart how he did it.
Now sure to understand: did we charry-pick some work from the original busboy repo? - In case I would add credits
@Uzlopak Can you resolve the conflicts? |
@Uzlopak what are the benchmarks agains the master? |
@kibertoad |
@Uzlopak can you run benchmark to see the perf difference? |
before: after: |
@kibertoad |
@Uzlopak We can rewrite to tinybench, photofinish main strength is that it allows running easily across Node versions, which is an overkill here. |
336318d
to
5dc9096
Compare
@kibertoad |
Based on the work of mscdex regarding the decodeText. Pretty smart how he did it.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct