Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase benchmark rounds to 10 #17

Merged
merged 2 commits into from
Nov 28, 2021
Merged

increase benchmark rounds to 10 #17

merged 2 commits into from
Nov 28, 2021

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 28, 2021

We need to increase the benchmark rounds to 10 to get realistic benchmarks. After 4 rounds it optimizes for maximum speed.

uzlopak@uzlopak-Lenovo-Legion-5-17ARH05H:~/Workspace/fastify/busboy$ npm run bench:dicer

> @fastify/busboy@1.0.0 bench:dicer
> node deps/dicer/bench/dicer-bench-multipart-parser.js

1515.15 mb/sec
1351.35 mb/sec
1333.33 mb/sec
2127.66 mb/sec
2127.66 mb/sec
2127.66 mb/sec
2127.66 mb/sec
2127.66 mb/sec
2173.91 mb/sec
2127.66 mb/sec

Checklist

@kibertoad
Copy link
Member

Would be nice to move the whole benchmark thing over to some proper benchmarking engine, but this is a welcome improvement until that happens :)

@kibertoad
Copy link
Member

linting is failing

@kibertoad kibertoad mentioned this pull request Nov 28, 2021
4 tasks
@kibertoad
Copy link
Member

I wonder if benchmark needs to be expanded to be run on less static data, otherwise its results are actually going to be less accurate due to optimizer tightly optimizing specifically for the one hardcoded path in the benchmark, e. g. completely disregarding potential megamorphism that would be present in real-world scenarios.

@kibertoad kibertoad merged commit 284318e into fastify:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants