Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comments, the maxHeaderSize should be actually be corresponding to the node http modules maxHeaderSize value. But it is actually wrong, as the default maxHeaderSize is and was always 8 kb and not 80 kb. On the other hand, the header of a request is different than the header of a multipart.
With this PR we expose headerSize as configurable limit. So if somebody wants to reduce the allowed size of a header, it is now possible to set the limit.
This PR is non-breaking, as the original 80 kbytes are still enforced. Maybe we should inform in a security part of the readme.md that we recommend to reduce the header size to something smaller.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct