Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: save additional functions in context array #455

Conversation

ivan-tymoshenko
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko commented Jun 6, 2022

Checklist

index.js Outdated
@@ -55,6 +55,7 @@ const objectReferenceSerializersMap = new Map()
const schemaReferenceMap = new Map()

let ajvInstance = null
let contextFunctions = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please initialize this to null instead, so it's clear it is reset later.

@ivan-tymoshenko ivan-tymoshenko force-pushed the save-additional-functions-in-context-array branch from 23bcf00 to fc1978b Compare June 9, 2022 09:07
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4c9374e into fastify:master Jun 9, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the save-additional-functions-in-context-array branch June 9, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants