deps: use json-schema-ref-resolver #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Oct 21, 2023
test/ref.test.js
Outdated
| @@ -1377,7 +1377,7 @@ test('Bad key', t => { | |||
| }) | |||
| t.fail('Should throw') | |||
| } catch (err) { | |||
| t.equal(err.message, 'Cannot find reference "extrenal#/definitions/projectId"') | |||
| t.equal(err.message, 'Schema with id "extrenal" is not found.') | |||
There was a problem hiding this comment.
the error message is less specific
There was a problem hiding this comment.
not a problem to fix that
There was a problem hiding this comment.
I don't see how it's a breaking change. Tests are passing. This package was developed from the ref-resolver.js module. If you look at the implementation of the methods that are used, you will see that it's the same code. The code that is used inside of |
Eomm
approved these changes
Oct 21, 2023
|
@ivan-tymoshenko could you resolve the conflicts? |
ivan-tymoshenko
force-pushed
the
use-json-schema-ref-resolver
branch
from
d6d810d
to
19c1c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/fastify/json-schema-ref-resolver