fix: update fjs_type validation to check for toJSON method #781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-present
and the Code of conduct
This PR fixes an issue where custom object formats failed during serialization when nested inside a
Union
type (check #779).Previously, the
fjs_type
keyword was used to support JavaScriptDate
objects, since Ajv does not natively validate them. This PR extends that logic to all objects implementing a.toJSON()
method, ensuring they are serialized correctly (for example, MongoDBObjectId
).Key Points
✅ Extends
fjs_type
handling beyond Date to any.toJSON()
-capable object.✅ Ensures correct serialization for custom formats like
ObjectId
.✅ Backward compatibility is preserved since
Date
objects already implement.toJSON()
(returning an ISO string).