This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 30
fix unit tests, replace pem with self-cert #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strange. locally it runs?! |
Uzlopak
changed the title
fix unit tests, generate private-key.pem
fix unit tests, replace pem with selfsigned
Dec 7, 2022
Uzlopak
changed the title
fix unit tests, replace pem with selfsigned
fix unit tests, replace pem with self-cert
Dec 7, 2022
OK, replaced pem with self-cert. First replaced it with selfsigned, but then I realized that self-cert is made by @jsumners so I use that instead. |
For what it's worth, I don't care which one is used as long as it works. But I was planning to point out fastify/fastify#3711 as the way to go about it. |
jsumners
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you. |
Eomm
reviewed
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont need to make big changes, to get the unit tests running again. Created a RSA private key and just supply it to pem, avoiding to make big refactoring.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct