-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for env integration #125
Conversation
are those needed to be jest-tests? I think these can get better with tap (as they'd run in parallel). I would also recommend using spawn instead of spawnSync and keep things asynchronous. |
I can use tap for the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
this PR is ignored in space. |
Sorry for the delay, I hoped somebody else would take a look |
Resolve #102
I do not know if it is the right approach for testing
ts-node
andts-node-dev
integration. But I think it is the only way to see if it is working properly.The two test case increase the test time from 1S to 8S and I think it is not worth for such two test case.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct