test: prefix unused params with underscores (#202)

fastify · Jan 3, 2025 · fe70605 · fe70605
1 parent 1bfce16
commit fe70605
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/examples/example.js b/examples/example.js
@@ -6,7 +6,7 @@ const bearerAuthPlugin = require('..')
 const keys = new Set(['key'])
 
 fastify.register(bearerAuthPlugin, { keys })
-fastify.get('/foo', (req, reply) => {
+fastify.get('/foo', (_req, reply) => {
   reply.send({ authenticated: true })
 })
 

diff --git a/test/decorate-with-logger.test.js b/test/decorate-with-logger.test.js
@@ -10,7 +10,7 @@ test('verifyBearerAuth with debug log', async (t) => {
 
   const logs = []
   const destination = new stream.Writable({
-    write: function (chunk, encoding, next) {
+    write: function (chunk, _encoding, next) {
       logs.push(JSON.parse(chunk))
       next()
     }
@@ -23,7 +23,7 @@ test('verifyBearerAuth with debug log', async (t) => {
     onRequest: [
       fastify.verifyBearerAuth
     ]
-  }, async (request, reply) => {
+  }, async (_request, _reply) => {
     return { message: 'ok' }
   })
 

diff --git a/test/integration.test.js b/test/integration.test.js
@@ -6,7 +6,7 @@ const plugin = require('../')
 
 fastify.register(plugin, { keys: new Set(['123456']) })
 
-fastify.get('/test', (req, res) => {
+fastify.get('/test', (_req, res) => {
   res.send({ hello: 'world' })
 })
 
@@ -56,7 +56,7 @@ test('missing header route fails correctly', async (t) => {
   t.assert.strictEqual(JSON.parse(response.body).error, 'missing authorization header')
 })
 
-test('integration with @fastify/auth', async (t) => {
+test('integration with @fastify/auth', async () => {
   const fastify = require('fastify')()
   await fastify.register(plugin, { addHook: false, keys: new Set(['123456']) })
   fastify.decorate('allowAnonymous', function (request, _, done) {
@@ -115,10 +115,10 @@ test('integration with @fastify/auth', async (t) => {
   })
 })
 
-test('integration with @fastify/auth; not the last auth option', async (t) => {
+test('integration with @fastify/auth; not the last auth option', async () => {
   const fastify = require('fastify')()
   await fastify.register(plugin, { addHook: false, keys: new Set(['123456']) })
-  fastify.decorate('alwaysValidAuth', function (request, _, done) {
+  fastify.decorate('alwaysValidAuth', function (_request, _, done) {
     return done()
   })
   await fastify.register(require('@fastify/auth'))

diff --git a/test/spec-compliance-rfc-6749.test.js b/test/spec-compliance-rfc-6749.test.js
@@ -6,7 +6,7 @@ const plugin = require('../')
 
 fastify.register(plugin, { keys: new Set(['123456']), specCompliance: 'rfc6749' })
 
-fastify.get('/test', (req, res) => {
+fastify.get('/test', (_req, res) => {
   res.send({ hello: 'world' })
 })
 

diff --git a/test/spec-compliance-rfc-6750.test.js b/test/spec-compliance-rfc-6750.test.js
@@ -6,7 +6,7 @@ const plugin = require('../')
 
 fastify.register(plugin, { keys: new Set(['123456']), specCompliance: 'rfc6750' })
 
-fastify.get('/test', (req, res) => {
+fastify.get('/test', (_req, res) => {
   res.send({ hello: 'world' })
 })
 

diff --git a/test/verify-bearer-auth-factory.test.js b/test/verify-bearer-auth-factory.test.js
@@ -282,7 +282,7 @@ test('hook accepts correct header with auth function (promise)', (t) => {
     send
   }
 
-  function send (body) {
+  function send (_body) {
     t.assert.ifError('should not happen')
   }
 
@@ -309,7 +309,7 @@ test('hook accepts correct header with auth function (non-promise)', (t) => {
     send
   }
 
-  function send (body) {
+  function send (_body) {
     t.assert.ifError('should not happen')
   }
 

diff --git a/types/index.test-d.ts b/types/index.test-d.ts
@@ -4,7 +4,7 @@ import bearerAuth, { FastifyBearerAuthOptions, verifyBearerAuth, verifyBearerAut
 
 const pluginOptions: FastifyBearerAuthOptions = {
   keys: new Set(['foo']),
-  auth: (key: string, req: FastifyRequest) => { return true },
+  auth: (_key: string, _req: FastifyRequest) => { return true },
   errorResponse: (err: Error) => { return { error: err.message } },
   contentType: '',
   bearerType: '',
@@ -13,15 +13,15 @@ const pluginOptions: FastifyBearerAuthOptions = {
 
 const pluginOptionsAuthPromise: FastifyBearerAuthOptions = {
   keys: new Set(['foo']),
-  auth: (key: string, req: FastifyRequest) => { return Promise.resolve(true) },
+  auth: (_key: string, _req: FastifyRequest) => { return Promise.resolve(true) },
   errorResponse: (err: Error) => { return { error: err.message } },
   contentType: '',
   bearerType: ''
 }
 
 const pluginOptionsKeyArray: FastifyBearerAuthOptions = {
   keys: ['foo'],
-  auth: (key: string, req: FastifyRequest) => { return Promise.resolve(true) },
+  auth: (_key: string, _req: FastifyRequest) => { return Promise.resolve(true) },
   errorResponse: (err: Error) => { return { error: err.message } },
   contentType: '',
   bearerType: ''