Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scoped autoload and sensible dependencies #484

Merged
merged 2 commits into from
May 12, 2022

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented May 12, 2022

Fixes #483

Checklist

@mcollina mcollina requested a review from climba03003 May 12, 2022 10:22
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missing update the of generate.js.

fastify-cli/generate.js

Lines 24 to 30 in 5ab4e56

dependencies: {
fastify: cliPkg.dependencies.fastify,
'fastify-plugin': cliPkg.devDependencies['fastify-plugin'] || cliPkg.dependencies['fastify-plugin'],
'fastify-autoload': cliPkg.devDependencies['fastify-autoload'],
'fastify-sensible': cliPkg.devDependencies['fastify-sensible'],
'fastify-cli': '^' + cliPkg.version
},

fastify-cli/generate.js

Lines 53 to 59 in 5ab4e56

dependencies: {
fastify: cliPkg.dependencies.fastify,
'fastify-plugin': cliPkg.devDependencies['fastify-plugin'] || cliPkg.dependencies['fastify-plugin'],
'fastify-autoload': cliPkg.devDependencies['fastify-autoload'],
'fastify-sensible': cliPkg.devDependencies['fastify-sensible'],
'fastify-cli': '^' + cliPkg.version
},

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
Copy link
Member Author

I didn't commit the changes. Lol.

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit ed7aa30 into master May 12, 2022
@Fdawgs Fdawgs deleted the add-autoload-sensible-deps branch August 10, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New project is generated without dependencies on namespaced @fastify/sensible, and @fastify/autoload
3 participants