Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript defs #121

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Update typescript defs #121

merged 1 commit into from
Aug 6, 2020

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Aug 6, 2020

Simplify the types

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • commit message and code follows Code of conduct

@mcollina mcollina requested review from fox1t and delvedor August 6, 2020 17:36
delvedor
delvedor approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3006ce7 into master Aug 6, 2020
@mcollina mcollina deleted the update-ts branch August 6, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@fox1t fox1t Awaiting requested review from fox1t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @delvedor