Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: allow-list only needed files for packaging #221

Closed

Conversation

castarco
Copy link

In this small patch I add a short allowList to the package.json file, to ensure that only essential files are added to the distributed package.

  • The package in its compressed form goes down from 13512 bytes to 9295 bytes (around 31% less)
  • In its decompressed form, goes from 79.5kB to 40.9kB (around 48% less)

It can be checked by running npm pack and inspecting the generated artifacts.

Signed-off-by: Andres Correa Casablanca castarco@coderspirit.xyz

Checklist

Signed-off-by: Andres Correa Casablanca <castarco@coderspirit.xyz>
@jsumners
Copy link
Member

Thank you for your interest in this topic. Please see the discussion in fastify/skeleton#42 (comment) for my reasoning against such a change.

@Eomm Eomm closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants