Skip to content

perf: only call removeHeader when needed #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2023
Merged

perf: only call removeHeader when needed #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0d05ee
only call removeHeader when needed
gurgunday Aug 1, 2023
79c0b79
clear in all conditions
gurgunday Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ function fastifyCookieSetCookie (reply, name, value, options) {

if (reply[kReplySetCookiesHookRan]) {
setCookies(reply)
reply[kReplySetCookies].clear()
}

return reply
Expand Down Expand Up @@ -71,14 +70,17 @@ function onReqHandlerWrapper (fastify, hook) {

function setCookies (reply) {
let setCookie = reply.getHeader('Set-Cookie')
const setCookieIsUndefined = setCookie === undefined

/* istanbul ignore else */
if (setCookie === undefined) {
if (setCookieIsUndefined) {
if (reply[kReplySetCookies].size === 1) {
for (const c of reply[kReplySetCookies].values()) {
reply.header('Set-Cookie', cookie.serialize(c.name, c.value, c.opts))
}

reply[kReplySetCookies].clear()

return
}

Expand All @@ -91,14 +93,14 @@ function setCookies (reply) {
setCookie.push(cookie.serialize(c.name, c.value, c.opts))
}

reply.removeHeader('Set-Cookie')
if (!setCookieIsUndefined) reply.removeHeader('Set-Cookie')
reply.header('Set-Cookie', setCookie)
reply[kReplySetCookies].clear()
}

function fastifyCookieOnSendHandler (fastifyReq, fastifyRes, payload, done) {
if (fastifyRes[kReplySetCookies].size) {
setCookies(fastifyRes)
fastifyRes[kReplySetCookies].clear()
}

fastifyRes[kReplySetCookiesHookRan] = true
Expand Down