Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: merge duplicate FastifyCookieOptions interface exports #318

Merged
merged 2 commits into from
Jan 5, 2025
Merged

types: merge duplicate FastifyCookieOptions interface exports #318

merged 2 commits into from
Jan 5, 2025
+10 −16

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 5, 2025 •
edited
Loading

Resolves linting errors. See https://github.com/fastify/fastify-cookie/actions/runs/12611531804/job/35147292328

Also fixed duplicate imports in tests that the linter highlighted.

Checklist

dancastillo
dancastillo approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fdawgs
Update types/plugin.d.ts
c2124ba 
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
@Fdawgs Fdawgs merged commit 24a5844 into master Jan 5, 2025
13 checks passed
@Fdawgs Fdawgs deleted the types/dupe branch January 5, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancastillo dancastillo dancastillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @dancastillo