Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dependabot): ignore tap major updates #276

Merged
merged 1 commit into from
Nov 2, 2023
Merged

build(dependabot): ignore tap major updates #276

merged 1 commit into from
Nov 2, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 31, 2023

Example mass update PR for fastify/fastify#5116

Checklist

@Fdawgs Fdawgs marked this pull request as ready for review October 31, 2023 19:39
@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 31, 2023

@fastify/plugins can run a mass update of tap and dependabot for all repos, which will save someone from having to do it manually as part of the v5 work. wdyt?

@Uzlopak
Copy link
Contributor

Uzlopak commented Oct 31, 2023

Is the answer from openjs or what it was regarding the use of tap as dev depency negative?
I would like to have this clarified, before we restrict us.

@jsumners
Copy link
Member

jsumners commented Nov 1, 2023

I would not hold my breath waiting on a licensing decision. It's going to take probably as long to get it as it will to prepare v5.

@marco-ippolito
Copy link

marco-ippolito commented Nov 1, 2023

the license has not been approved yet afaik, similar problem with npm in node
cc @mcollina

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I told to dependabot to ignore the dep by commenting the PRs in many repos TBH

PS: the pinned version does not have the new licence:
https://www.npmjs.com/package/tap/v/16.3.9

@Eomm Eomm merged commit 702d440 into master Nov 2, 2023
21 checks passed
@Eomm Eomm deleted the build/tap branch November 2, 2023 06:59
renovate bot referenced this pull request in tomacheese/telcheck Dec 4, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/cors](https://togithub.com/fastify/fastify-cors) | [`8.4.1`
->
`8.4.2`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.4.1/8.4.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcors/8.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcors/8.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcors/8.4.1/8.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcors/8.4.1/8.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cors (@&#8203;fastify/cors)</summary>

###
[`v8.4.2`](https://togithub.com/fastify/fastify-cors/releases/tag/v8.4.2)

[Compare
Source](https://togithub.com/fastify/fastify-cors/compare/v8.4.1...v8.4.2)

#### What's Changed

- build(dependabot): ignore tap major updates by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/276](https://togithub.com/fastify/fastify-cors/pull/276)
- fix: support for embedded cors for route params by
[@&#8203;mohammedSlimani](https://togithub.com/mohammedSlimani) in
[https://github.com/fastify/fastify-cors/pull/278](https://togithub.com/fastify/fastify-cors/pull/278)

#### New Contributors

- [@&#8203;mohammedSlimani](https://togithub.com/mohammedSlimani) made
their first contribution in
[https://github.com/fastify/fastify-cors/pull/278](https://togithub.com/fastify/fastify-cors/pull/278)

**Full Changelog**:
fastify/fastify-cors@v8.4.1...v8.4.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants