types: check error argument type

[trim21]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• code follows the Developer's Certification of Origin
  and the Code of conduct

const CustomTypedArgError = createError<[string]>('OTHER_CODE', 'expect %s message', 400)

CustomTypedArgError('a')
// @ts-expect-error
CustomTypedArgError('a', 'b')
// @ts-expect-error
new CustomTypedArgError('a', 'b')
// @ts-expect-error
CustomTypedArgError(1)
// @ts-expect-error
new CustomTypedArgError(1)

[trim21]

some minor space change.

[Fdawgs]

Please revert prettier style changes, this repo uses Standard.

[trim21]

Yes but it pass npm run lint, there is no conflict here. Standard doesn't enforce when to break line or you write { createError as default } or {createError as default}

[trim21]

Oh i see, standard is broken in TypeScript, ts files are not checked.

[Uzlopak]

Also please use expectError of tsd, instead of ts-expect-error declarations

[mcollina]

lgtm

[trim21]

any plan on merging this?

[Uzlopak]

Can you extend the typings tests to this, please?

const CustomTypedArgError = createError<[string]>('OTHER_CODE', 'expect %s message', 400)
CustomTypedArgError('a')
new CustomTypedArgError('a')
expectError(CustomTypedArgError('a', 'b'))
expectError(new CustomTypedArgError('a', 'b'))
expectError(CustomTypedArgError(1))
expectError(new CustomTypedArgError(1))

const CustomTypedArgError2 = createError<string, number, [string]>('OTHER_CODE', 'expect %s message', 400)
CustomTypedArgError2('a')
new CustomTypedArgError2('a')
expectError(CustomTypedArgError2('a', 'b'))
expectError(new CustomTypedArgError2('a', 'b'))
expectError(CustomTypedArgError2(1))
expectError(new CustomTypedArgError2(1))

const CustomTypedArgError3 = createError<string, number, [string, string]>('OTHER_CODE', 'expect %s message but got %s', 400)
expectError(CustomTypedArgError3('a'))
CustomTypedArgError3('a', 'b')
new CustomTypedArgError3('a', 'b')
expectError(CustomTypedArgError3(1))
expectError(new CustomTypedArgError3(1))
expectError(new CustomTypedArgError3(1,2))
expectError(new CustomTypedArgError3('1',2))
expectError(new CustomTypedArgError3(1,'2'))

const CustomTypedArgError4 = createError<string, number, [string, string]>('OTHER_CODE', 'expect %s message but got %s', 400)
expectError(CustomTypedArgError4('a'))
CustomTypedArgError4('a', 'b')
new CustomTypedArgError4('a', 'b')
expectError(CustomTypedArgError4(1))
expectError(new CustomTypedArgError4(1))
expectError(new CustomTypedArgError4(1,2))
expectError(new CustomTypedArgError4('1',2))
expectError(new CustomTypedArgError4(1,'2'))


const CustomTypedArgError5 = createError<[string, string, string, string]>('OTHER_CODE', 'expect %s message but got %s. Please contact %s by emailing to %s', 400)
expectError(CustomTypedArgError5('a'))
expectError(new CustomTypedArgError5('a', 'b'))
expectError(new CustomTypedArgError5('a', 'b', 'c'))
CustomTypedArgError5('a', 'b', 'c', 'd')
expectError(new CustomTypedArgError5('a', 'b', 'c', 'd', 'e'))

const CustomTypedArgError6 = createError<string, number, [string, string, string, string]>('OTHER_CODE', 'expect %s message but got %s. Please contact %s by emailing to %s', 400)
expectError(CustomTypedArgError6('a'))
expectError(new CustomTypedArgError6('a', 'b'))
expectError(new CustomTypedArgError6('a', 'b', 'c'))
CustomTypedArgError6('a', 'b', 'c', 'd')
expectError(new CustomTypedArgError6('a', 'b', 'c', 'd', 'e'))

[Uzlopak]

The functionality is given, but to check if everything is correct, I needed to modify the typings test. I would like to get that added to this PR. I would than merge it.

[Uzlopak]

LGTM

[Uzlopak]

LGTM

[trim21]

/ping

[Uzlopak]

I didnt forget you ;). I tried to merge it about 10 times when github had issues.

[trim21]

New release for this?

[Uzlopak]

Well this is some job for @mcollina , @Eomm and so.