Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: isn't return null correct compared to empty string? #4

Open
adityapatadia opened this issue Jul 8, 2019 · 5 comments
Open

Comments

@adityapatadia
Copy link

https://github.com/fastify/fastify-etag/blob/master/index.js#L35

@adityapatadia
Copy link
Author

@mcollina
Copy link
Member

mcollina commented Jul 8, 2019

Good spot! Would you like to send a PR?

@kurtextrem
Copy link
Contributor

Looks like this can be closed, looking at the closed PR?

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 8, 2023

@kurtextrem

I tink this issue is still relevant, and the PR was closed due to more than 1 year inactivity.

@kurtextrem
Copy link
Contributor

@Uzlopak I'm not entirely sure. The docs mention Content-length is not set when you return null, but @mcollina mentions we should set content-length manually to 0 if we want to return null.
So for me it's the same just different, which tells me we should keep it like it is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants