Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send null for 304 response instead of empty string #5

Closed
wants to merge 2 commits into from
Closed

send null for 304 response instead of empty string #5

wants to merge 2 commits into from

Conversation

adityapatadia
Copy link

@adityapatadia adityapatadia commented Jul 8, 2019

closes #4

@mcollina
Copy link
Member

mcollina commented Jul 8, 2019

CI is failing

@mcollina
Copy link
Member

mcollina commented Jul 8, 2019

Returning an empty string set the content-length to zero. We need to set it manually to 0 if we want to use null.

@mcollina mcollina closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: isn't return null correct compared to empty string?
2 participants