Change decorator name #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed decorator name to avoid conflict with @fastify/passport plugin using the same decorator
jsumners
reviewed
May 27, 2022
Done, hope it's ok now |
mcollina
requested changes
May 27, 2022
jwt.js
Outdated
| @@ -142,9 +142,10 @@ function fastifyJwt (fastify, options, next) { | |||
| let jwtDecodeName = 'jwtDecode' | |||
| let jwtVerifyName = 'jwtVerify' | |||
| let jwtSignName = 'jwtSign' | |||
| const jwtDecoratorName = process.env.JWT_DECORATOR_NAME || 'user' | |||
There was a problem hiding this comment.
please use an option to the plugin, not an env variable.
jsumners
reviewed
May 28, 2022
| @@ -2714,3 +2714,23 @@ test('global user options should not be modified', async function (t) { | |||
| t.equal(fastify.jwt.options.sign.notBefore, '4 hours') | |||
| t.equal(fastify.jwt.options.verify.maxAge, 2000) | |||
| }) | |||
|
|
|||
| test('decorator name should work after being changed in the options', async function (t) { | |||
There was a problem hiding this comment.
This test is missing an assertion that the custom decorator name is present.
There was a problem hiding this comment.
I included new tests asserting the new decorator name. Also updated the docs
jsumners
reviewed
May 30, 2022
| const token = JSON.parse(signResponse.payload).token | ||
| t.ok(token) | ||
| t.ok(fastify.jwt.options.decoratorName) | ||
| t.equal(fastify.jwt.options.decoratorName, decoratorName) |
There was a problem hiding this comment.
This is a good assertion. But there really should be one that verifies the decoration on the request object.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed decorator name to avoid conflict with @fastify/passport plugin using the same decorator
Checklist
npm run testandnpm run benchmarkand the Code of conduct