Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): mongodb@5 #213

Merged
merged 4 commits into from
Mar 29, 2023
Merged

fix(docs): mongodb@5 #213

merged 4 commits into from
Mar 29, 2023

Conversation

pip77
Copy link
Contributor

@pip77 pip77 commented Mar 29, 2023

looking into this merged PR, it seems like you are using mongodb v5.x.x already and callbacks are not working anymore.

Checklist

@pip77
fix(docs): mongodb@5
c827a84 
looking into this merged PR, it seems like you are using mongodb v5.x.x already and callbacks are not working anymore.
@pip77 pip77 mentioned this pull request Mar 29, 2023
Merged
4 tasks
climba03003
climba03003 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, forgotten the documentation changes.

LGTM.

Eomm
Eomm reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using an async handler, we should promote return instead of reply.send

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pip77 and others added 3 commits March 29, 2023 14:27
@pip77 @Eomm
replace reply.send with return
cdb5184 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@pip77 @Eomm
replace reply.send with return
7ebd6ff 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@pip77
rm reply.send
94b7cbe
@pip77 pip77 requested a review from Eomm March 29, 2023 12:28
mcollina
mcollina approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7f76135 into fastify:master Mar 29, 2023
@pip77 pip77 deleted the fix-docs-mongodb5 branch March 30, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pip77 @mcollina @Eomm @climba03003