Failing test on windows 10

[gfellerph]

🐛 Bug Report

The multipart test is failing to call finished when both files are pumped.

test/multipart.test.js .............................. 47/48 12s
should call finished when both files are pumped
not ok should be equal
--- wanted
+++ found
-2
+0
compare: ===
at:
line: 97
column: 9
file: test/multipart.test.js
type: Immediate
method: _onImmediate
stack: |
Immediate._onImmediate (test/multipart.test.js:97:9)
source: |
t.equal(fileCount, 2)

total ............................................. 105/106

To Reproduce

Steps to reproduce the behavior:
Clone the repository, run npm install and then npm run test

Your Environment

• node version: v12.10.0
• fastify-multipart version: 1.0.3
• os: Windows 10 Pro 64bit

[mcollina]

are you able to send a PR to fix it? Thanks!

[gfellerph]

I actually don't know if it's just me. If anybody else can reproduce the bug on windows I'll look into it.

[Eomm]

Unfortunately, I had this problem and it is a matter of optimization of the PC.

For example if you write this handler in the should call finished when both files are pumped test:

    function handler (field, file, filename, encoding, mimetype) {
      pump(file, new (require('stream').Writable)({
        write (chunk, encoding, done) {
          done()
        }
      }), function (err) {
        t.error(err)
        fileCount++
      })
    }

All will works

Causes: HDD latency + battery saving mode +❓

For this reason, we have windows in our CI 😅

[gfellerph]

@Eomm, I tested your code and the test passes now. Should I submit a PR?

[mcollina]

Yes! Il giorno lun 23 dic 2019 alle ore 20:39 Philipp Gfeller < notifications@github.com> ha scritto:

…

@Eomm <https://github.com/Eomm>, I tested your code and the test passes now. Should I submit a PR? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#110?email_source=notifications&email_token=AAAMXY6CRX5OL5D4T2TRI5LQ2EHWBA5CNFSM4J6SMRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRZQOI#issuecomment-568563769>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMXY2JGA4H5PW5QZI6K3TQ2EHWBANCNFSM4J6SMRLQ> .

[Eomm]

Not sure why we saved the files in a temporary directory

Check it out please

[StarpTech]

This should be finally fixed with the new promise API which works flawlessly on windows #140

[StarpTech]

Closing due to inactivity.