-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (coverage): remove statements not needed since fastify@3.22.1
#463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just remove both statements, we only support the latest release of Fastify anyway.
Could you bump the fastify dep on package.json too?
Should I bump the minimum required Currently require module.exports = fp(fastifyNext, {
fastify: '>=1.0.0',
name: 'fastify-nextjs'
}) |
fastify@3.22.1
fastify@3.22.1
Not sure about it because someone out there could be using Fastify v2 and this plugin (and I know this is not a hypothesis). |
let's bump the minimum dependency on Fastify (and use the ~ instead of the ^) and bump the major. |
@Eomm > yeah this is why at first I just added an Anyway with those 2 statements being removed we must land this as a major since this is a breaking change with fastify <= v3.22.0 |
@mcollina > I already bumped all dependencies to their latest (both in |
(waiting before merge: there are a |
Hello.
This PR aims to :
fastify@3.22.1
fastify
dependency by our GitHub action workflowFor reference:
Checklist
npm run test
andnpm run benchmark
and the Code of conduct