Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (coverage): remove statements not needed since fastify@3.22.1 #463

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Jan 22, 2022

Hello.

This PR aims to :

  • remove 2 statements that are not needed since the release of fastify@3.22.1
  • unlock the upgrade of fastify dependency by our GitHub action workflow
  • upgrade package dependencies (fix Update dependencies #470)

For reference:

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove both statements, we only support the latest release of Fastify anyway.

Could you bump the fastify dep on package.json too?

@darkgl0w
Copy link
Member Author

darkgl0w commented Jan 22, 2022

Should I bump the minimum required fastify version to >=3.22.1 too ?

Currently require fastify@1.0.0 or greater:

module.exports = fp(fastifyNext, {
  fastify: '>=1.0.0',
  name: 'fastify-nextjs'
})

@darkgl0w darkgl0w changed the title fix (coverage): ignore statements not needed since fastify@3.22.1 fix (coverage): remove statements not needed since fastify@3.22.1 Jan 22, 2022
@Eomm
Copy link
Member

Eomm commented Jan 23, 2022

Should I bump the minimum required fastify version to >=3.22.1 too ?

Not sure about it because someone out there could be using Fastify v2 and this plugin (and I know this is not a hypothesis).
If we do it, we should bump a major.

@mcollina
Copy link
Member

let's bump the minimum dependency on Fastify (and use the ~ instead of the ^) and bump the major.

@darkgl0w
Copy link
Member Author

@Eomm > yeah this is why at first I just added an istanbul ignore next command without removing the check. Like this it allowed to ensure compatibility with old fastify version.

Anyway with those 2 statements being removed we must land this as a major since this is a breaking change with fastify <= v3.22.0

@darkgl0w
Copy link
Member Author

let's bump the minimum dependency on Fastify (and use the ~ instead of the ^) and bump the major.

@mcollina > I already bumped all dependencies to their latest (both in package.json and package-lock.json) it should be enough and with this last change fastify plugin constraints will do the job if it detects an unsupported version ^^

@Eomm
Copy link
Member

Eomm commented Jan 23, 2022

(waiting before merge: there are a minor in pipeline to release first)

@Eomm Eomm merged commit beaac97 into fastify:master Jan 28, 2022
@darkgl0w darkgl0w deleted the coverage-workaround branch March 13, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
3 participants