Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package-lock.json #538

Merged
merged 1 commit into from
May 15, 2022

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented May 11, 2022

I found package-lock.json is not up to date when I setup local development environment

Checklist

@Fdawgs
Copy link
Member

Fdawgs commented May 11, 2022

Do we need the package-lock with this repo?

@is2ei
Copy link
Contributor Author

is2ei commented May 11, 2022

@Fdawgs
I'm not sure the reason but it is committed 2 years ago.
Ref: b31e28b

@Fdawgs
Copy link
Member

Fdawgs commented May 11, 2022

@Fdawgs I'm not sure the reason but it is committed 2 years ago. Ref: b31e28b

@mcollina, any ideas? All of the other fastify plugins (besides fastify-passport and this repo) don't include the lock file.

@mcollina
Copy link
Member

Because next and its ecosystem regularly broke our tests in minor releases.

@mcollina mcollina merged commit d67f2fa into fastify:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants