Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update under-pressure -> @fastify/under-pressure #550

Merged
merged 1 commit into from
Jun 10, 2022
Merged

fix: update under-pressure -> @fastify/under-pressure #550

merged 1 commit into from
Jun 10, 2022

Conversation

rriski
Copy link
Contributor

@rriski rriski commented Jun 10, 2022

Fixes #549.

Checklist

@rriski rriski mentioned this pull request Jun 10, 2022
Closed
2 tasks
@kibertoad
Copy link
Member

@Fdawgs I assume ci workflows need to be updated to v4 too?

@Fdawgs
Copy link
Member

Fdawgs commented Jun 10, 2022

@Fdawgs I assume ci workflows need to be updated to v4 too?

Nah, this repo is already using the shared workflow. 😸

@kibertoad kibertoad merged commit 105ef17 into fastify:master Jun 10, 2022
@rriski rriski deleted the fix/under-pressure-plugin branch June 10, 2022 12:01
@SimenB
Copy link
Member

SimenB commented Jun 13, 2022

Release? 😀

@SimenB
Copy link
Member

SimenB commented Jun 14, 2022 •
edited
Loading

@mcollina this should have been released in v9, no? @fastify/under-pressure@7 is fastify v4 only

@mcollina
Copy link
Member

Then this should not have been released at all

mcollina added a commit that referenced this pull request Jun 14, 2022
@mcollina
Revert "fix: update under-pressure -> @fastify/under-pressure (#550)"
57877e8 
This reverts commit 105ef17.
mcollina added a commit that referenced this pull request Jun 14, 2022
@mcollina
Restore fastify v3 compat (#556)
678c35b 
* Revert "fix: update under-pressure -> @fastify/under-pressure (#550)"

This reverts commit 105ef17.

* v8.0.0 is fastify@3.x only

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fastify v4 error: "under-pressure - expected '3.x' fastify version, '4.0.0' is installed"
5 participants
@rriski @kibertoad @Fdawgs @SimenB @mcollina