feat: options to customize cookie names #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
requested changes
Sep 22, 2024
index.js
Outdated
| const stateCookie = request.cookies['oauth2-redirect-state'] | ||
| const stateCookie = | ||
| request.cookies[ | ||
| this.redirectStateCookieName || DEFAULT_REDIRECT_STATE_COOKIE_NAME |
There was a problem hiding this comment.
this is a potential security issue - we can't try to read both cookie
There was a problem hiding this comment.
hmm, I don't think it is reading both. If you have provided redirectStateCookieName in options it will read request.cookies[this.redirectStateCookieName] otherwise it uses a default value and takes request.cookies[DEFAULT_REDIRECT_STATE_COOKIE_NAME] - never tries to read both.
index.js
Outdated
| @@ -116,10 +134,14 @@ function fastifyOauth2 (fastify, options, next) { | |||
| tokenRequestParams = {}, | |||
| scope, | |||
| generateStateFunction = defaultGenerateStateFunction, | |||
| checkStateFunction = defaultCheckStateFunction, | |||
| checkStateFunction = defaultCheckStateFunction.bind({ | |||
| redirectStateCookieName: configured.redirectStateCookieName | |||
There was a problem hiding this comment.
Suggested change
| redirectStateCookieName: configured.redirectStateCookieName | |
| redirectStateCookieName: configured.redirectStateCookieName || DEFAULT_REDIRECT_STATE_COOKIE_NAME |
There was a problem hiding this comment.
oh, ok, I see. Sure I can move that default value from defaultCheckStateFunction here, it should effectively do the same
|
@Eomm PTAL |
Eomm
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I do realize that these are very short-lived cookies, but I have a project where I have to follow a naming convention for all cookies, so it would be great if we could customize these too.
Checklist
npm run testandnpm run benchmarkand the Code of conduct