Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clientClose to work #177

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Fix clientClose to work #177

merged 2 commits into from
Apr 10, 2023

Conversation

starnayuta
Copy link
Contributor

When clientClose is set to true, the client connection is automatically closed when the Fastify server shuts down.

Reported in issue #176

This PR was developed with respect to #66

Checklist

mcollina
mcollina approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 5f73081 into fastify:master Apr 10, 2023
@Eomm Eomm mentioned this pull request Apr 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@starnayuta @mcollina @Eomm