Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap ms out #132

Merged
merged 1 commit into from
May 3, 2023
Merged

swap ms out #132

merged 1 commit into from
May 3, 2023

Conversation

gurgunday
Copy link
Member

Checklist

@jsumners
Copy link
Member

Can you provide some justification for this change?

@gurgunday
Copy link
Member Author

Sure, many Fastify plugins have moved to this version of ms [1].

The main justification is consistency among the core plugins, it is supposed to be faster too, which is why it was adopted in the first place.

[1] (a) — https://github.com/fastify/send/blob/cf190d743d9ea07be0eab5f66b8793297c773858/package.json#L28
[1] (b) — https://github.com/fastify/fastify-jwt/blob/1aa4790668924572cca664d12b657b7d4e9f1dab/package.json#L35

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2fe0e07 into fastify:master May 3, 2023
@gurgunday gurgunday deleted the swap-ms branch May 4, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants