-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow #109 - removed remnants of error handler added by #18 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy#18 Signed-off-by: Lam Wei Li <lam_wei_li@hotmail.com>
mcollina
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
github-merge-queue bot
referenced
this pull request
in rustymotors/server
Sep 17, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/sensible](https://redirect.github.com/fastify/fastify-sensible) | [`^5.6.0` -> `^6.0.0`](https://renovatebot.com/diffs/npm/@fastify%2fsensible/5.6.0/6.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fsensible/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fsensible/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fsensible/5.6.0/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fsensible/5.6.0/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@fastify/sensible](https://redirect.github.com/fastify/fastify-sensible) | [`^5.6.0` -> `^6.0.0`](https://renovatebot.com/diffs/npm/@fastify%2fsensible/5.5.0/6.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fsensible/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fsensible/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fsensible/5.5.0/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fsensible/5.5.0/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>fastify/fastify-sensible (@​fastify/sensible)</summary> ### [`v6.0.0`](https://redirect.github.com/fastify/fastify-sensible/releases/tag/v6.0.0) [Compare Source](https://redirect.github.com/fastify/fastify-sensible/compare/v5.6.0...v6.0.0) #### What's Changed - perf: replace fast-deep-equal with dequal by [@​gurgunday](https://redirect.github.com/gurgunday) in [https://github.com/fastify/fastify-sensible/pull/160](https://redirect.github.com/fastify/fastify-sensible/pull/160) - Merge `next` into `master` by [@​jsumners](https://redirect.github.com/jsumners) in [https://github.com/fastify/fastify-sensible/pull/161](https://redirect.github.com/fastify/fastify-sensible/pull/161) - build(deps-dev): bump [@​types/node](https://redirect.github.com/types/node) from 20.14.13 to 22.0.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/fastify/fastify-sensible/pull/163](https://redirect.github.com/fastify/fastify-sensible/pull/163) - refactor: rename SensibleOptions into FastifySensibleOptions by [@​jean-michelet](https://redirect.github.com/jean-michelet) in [https://github.com/fastify/fastify-sensible/pull/162](https://redirect.github.com/fastify/fastify-sensible/pull/162) - build(deps): bump fastify/workflows from 4.1.0 to 5.0.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/fastify/fastify-sensible/pull/166](https://redirect.github.com/fastify/fastify-sensible/pull/166) - chore: update min fastify version by [@​Fdawgs](https://redirect.github.com/Fdawgs) in [https://github.com/fastify/fastify-sensible/pull/165](https://redirect.github.com/fastify/fastify-sensible/pull/165) - follow [#​109](https://redirect.github.com/fastify/fastify-sensible/issues/109) - removed remnants of error handler added by [#​18](https://redirect.github.com/fastify/fastify-sensible/issues/18) by [@​lamweili](https://redirect.github.com/lamweili) in [https://github.com/fastify/fastify-sensible/pull/164](https://redirect.github.com/fastify/fastify-sensible/pull/164) #### New Contributors - [@​jean-michelet](https://redirect.github.com/jean-michelet) made their first contribution in [https://github.com/fastify/fastify-sensible/pull/162](https://redirect.github.com/fastify/fastify-sensible/pull/162) - [@​lamweili](https://redirect.github.com/lamweili) made their first contribution in [https://github.com/fastify/fastify-sensible/pull/164](https://redirect.github.com/fastify/fastify-sensible/pull/164) **Full Changelog**: fastify/fastify-sensible@v5.6.0...v6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImRldiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109 dropped the error handler, but there are some remnants of it added by #18 that are not cleaned up.
This PR cleans them up and reverts the changes done by #18.
Checklist
npm run test
andnpm run benchmark
tests and/or benchmarks are includeddocumentation is changed or addedand the Code of conduct