Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export HttpError as class instead of interface #181

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Export HttpError as class instead of interface #181

merged 1 commit into from
Dec 14, 2024

Conversation

ryanrishi
Copy link
Contributor

Closes #177. Fixes #167.

Checklist

@ryanrishi ryanrishi mentioned this pull request Dec 13, 2024
Closed
4 tasks
dancastillo
dancastillo approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gurgunday gurgunday merged commit 72c6863 into fastify:master Dec 14, 2024
11 checks passed
@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 15, 2024

Actually would have expected that a typing test covers the fact that you can instantiate an error with new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@dancastillo dancastillo dancastillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpErrors.HttpError type export should be a class, not an interface
4 participants
@ryanrishi @Uzlopak @dancastillo @gurgunday