-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to @fastify/send v2 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Uzlopak
reviewed
Jan 30, 2023
Uzlopak
reviewed
Jan 30, 2023
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
@Uzlopak ptal |
@Uzlopak unfortunately it's not working |
fixed the linting issue + wrong function name (my fault regarding the suggestion i made before) |
Uzlopak
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ddadaal
referenced
this pull request
in PKUHPC/OpenSCOW
Jan 31, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.7.0` -> `6.8.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.7.0/6.8.0) | [![age](https://badges.renovateapi.com/packages/npm/@fastify%2fstatic/6.8.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@fastify%2fstatic/6.8.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@fastify%2fstatic/6.8.0/compatibility-slim/6.7.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@fastify%2fstatic/6.8.0/confidence-slim/6.7.0)](https://docs.renovatebot.com/merge-confidence/) | | [eslint](https://eslint.org) ([source](https://togithub.com/eslint/eslint)) | [`8.32.0` -> `8.33.0`](https://renovatebot.com/diffs/npm/eslint/8.32.0/8.33.0) | [![age](https://badges.renovateapi.com/packages/npm/eslint/8.33.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/eslint/8.33.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/eslint/8.33.0/compatibility-slim/8.32.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/eslint/8.33.0/confidence-slim/8.32.0)](https://docs.renovatebot.com/merge-confidence/) | | [pnpm](https://pnpm.io) ([source](https://togithub.com/pnpm/pnpm)) | [`7.26.1` -> `7.26.2`](https://renovatebot.com/diffs/npm/pnpm/7.26.1/7.26.2) | [![age](https://badges.renovateapi.com/packages/npm/pnpm/7.26.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/pnpm/7.26.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/pnpm/7.26.2/compatibility-slim/7.26.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/pnpm/7.26.2/confidence-slim/7.26.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static</summary> ### [`v6.8.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.8.0) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.7.0...v6.8.0) #### What's Changed - Update to [@​fastify/send](https://togithub.com/fastify/send) v2 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify-static/pull/358](https://togithub.com/fastify/fastify-static/pull/358) **Full Changelog**: fastify/fastify-static@v6.7.0...v6.8.0 </details> <details> <summary>eslint/eslint</summary> ### [`v8.33.0`](https://togithub.com/eslint/eslint/releases/tag/v8.33.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.32.0...v8.33.0) #### Features - [`2cc7954`](https://togithub.com/eslint/eslint/commit/2cc7954cdb1fed44e8a5d3c9b3ea1deceadb5e00) feat: add `restrictDefaultExports` option to no-restricted-exports rule ([#​16785](https://togithub.com/eslint/eslint/issues/16785)) (Nitin Kumar) #### Documentation - [`17f4be2`](https://togithub.com/eslint/eslint/commit/17f4be2b66deb81f4e9ffb3d6bdfb79f3fcf85a2) docs: Fix examples in no-multiple-empty-lines rule ([#​16835](https://togithub.com/eslint/eslint/issues/16835)) (jonz94) - [`9c7cfe3`](https://togithub.com/eslint/eslint/commit/9c7cfe33c4a39cf2c23529afe02030ea7f8acf70) docs: 'Source Code' content in 'Set up Development Environment' page ([#​16780](https://togithub.com/eslint/eslint/issues/16780)) (Ben Perlmutter) - [`ede5c64`](https://togithub.com/eslint/eslint/commit/ede5c6475469a905da4f559ab55f0ee73168a9d7) docs: Custom processors page ([#​16802](https://togithub.com/eslint/eslint/issues/16802)) (Ben Perlmutter) - [`2620614`](https://togithub.com/eslint/eslint/commit/2620614f525de13f2e3ab0a7cd92abe89dae4897) docs: Code of Conduct page ([#​16781](https://togithub.com/eslint/eslint/issues/16781)) (Ben Perlmutter) - [`50a8efd`](https://togithub.com/eslint/eslint/commit/50a8efd957c70c9978a8ed25744a24193b00e078) docs: report a sec vulnerability page ([#​16808](https://togithub.com/eslint/eslint/issues/16808)) (Ben Perlmutter) - [`ed60afd`](https://togithub.com/eslint/eslint/commit/ed60afd4450e769a975447178299446f4439d926) docs: Update page titles, section landing pages, and side TOC ([#​16760](https://togithub.com/eslint/eslint/issues/16760)) (Ben Perlmutter) - [`333c712`](https://togithub.com/eslint/eslint/commit/333c71243537966930e9ab8178bc98c37949b5f2) docs: add background to code-path-diagrams for dark-mode ([#​16822](https://togithub.com/eslint/eslint/issues/16822)) (Tanuj Kanti) - [`f5f7b9b`](https://togithub.com/eslint/eslint/commit/f5f7b9b8b512f5c6a5b4a1037f81bb3f5a7311e0) docs: Update README (GitHub Actions Bot) - [`2aa4f5f`](https://togithub.com/eslint/eslint/commit/2aa4f5fb2fdb1c4a1734093c225e5c6251b0ee0f) docs: no-constant-condition: Add multi-comparison example ([#​16776](https://togithub.com/eslint/eslint/issues/16776)) (Sebastian Simon) - [`40287db`](https://togithub.com/eslint/eslint/commit/40287dbe7407934a69805f02ece07491778c3694) docs: Remove Google Group icon ([#​16779](https://togithub.com/eslint/eslint/issues/16779)) (Nicholas C. Zakas) - [`ea10ca5`](https://togithub.com/eslint/eslint/commit/ea10ca5b7b5bd8f6e6daf030ece9a3a82f10994c) docs: 'a .eslint' -> 'an .eslint' for consistency ([#​16809](https://togithub.com/eslint/eslint/issues/16809)) (Ben Perlmutter) - [`3be0748`](https://togithub.com/eslint/eslint/commit/3be07488ee7b6a9591d169be9648fbd36b32105e) docs: add example for nodejs lintText api ([#​16789](https://togithub.com/eslint/eslint/issues/16789)) (Siva K) - [`ce4f5ff`](https://togithub.com/eslint/eslint/commit/ce4f5ff30590df053a539c8e8e2597838e038a36) docs: Replace removed related rules with a valid rule ([#​16800](https://togithub.com/eslint/eslint/issues/16800)) (Ville Saalo) </details> <details> <summary>pnpm/pnpm</summary> ### [`v7.26.2`](https://togithub.com/pnpm/pnpm/releases/tag/v7.26.2) [Compare Source](https://togithub.com/pnpm/pnpm/compare/v7.26.1...v7.26.2) #### Patch Changes - Wrap text in `pnpm audit` output for better readability [#​5981](https://togithub.com/pnpm/pnpm/issues/5981) - Fix "cross-device link not permitted" error when `node-linker` is set to `hoisted` [#​5992](https://togithub.com/pnpm/pnpm/issues/5992). #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/nhost.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/nhost_light.svg" /> <img src="https://pnpm.io/img/users/nhost.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/novu.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/novu_light.svg" /> <img src="https://pnpm.io/img/users/novu.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/prisma.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/prisma_light.svg" /> <img src="https://pnpm.io/img/users/prisma.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://www.flightcontrol.dev/?ref=pnpm" target="_blank"><img src="https://pnpm.io/img/users/flightcontrol.png" width="240"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <img src="https://pnpm.io/img/users/leniolabs.jpg" width="80"> </a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/vercel.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/vercel_light.svg" /> <img src="https://pnpm.io/img/users/vercel.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <img src="https://pnpm.io/img/users/takeshape.svg" width="280"> </a> </td> <td align="center" valign="middle"> <a href="https://doppler.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/doppler.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/doppler_light.svg" /> <img src="https://pnpm.io/img/users/doppler.svg" width="280" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://depot.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/depot.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/depot_light.svg" /> <img src="https://pnpm.io/img/users/depot.svg" width="200" /> </picture> </a> </td> </tr> </tbody> </table> </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/PKUHPC/SCOW). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTYuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExNi4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matteo Collina hello@matteocollina.com
Checklist
npm run test
andnpm run benchmark
and the Code of conduct