perf: use node: prefix to bypass require.cache call for builtins

[Fdawgs]

See https://github.com/nodejs/node/pull/37246/files#r588397158 and https://nodejs.org/api/modules.html#core-modules

Checklist

• run npm run test and npm run benchmark
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Fdawgs]

Seem to be getting test failures locally even on master, using both 18.17.1 and 20.6.0

[gurgunday]

It might be because of a test that modifies/mocks a built-in module

[gurgunday]

Modifying static.test.js (L2822) fixes the issue

t.test(
  'register with rootpath that causes statSync to fail with non-ENOENT code',
  (t) => {
    const fastifyStatic = proxyquire('../', {
      'node:fs': { // HERE: fs -> 'node:fs'
        statSync: function statSyncStub (path) {
          throw new Error({ code: 'MOCK' })
        }
      }
    })

    const pluginOptions = {
      root: path.join(__dirname, '/static'),
      wildcard: true
    }
    const fastify = Fastify()
    fastify.register(fastifyStatic, pluginOptions)

    t.teardown(fastify.close.bind(fastify))
    fastify.listen({ port: 0 }, (err) => {
      fastify.server.unref()
      t.ok(err)
      t.end()
    })
  }
)

[Eomm]

I was today years old...

Core modules can be identified using the node: prefix, in which case it bypasses the require cache. For instance, require('node:http') will always return the built in HTTP module, even if there is require.cache entry by that name.

Didn't know it

LGTM on green pipeline 👍🏼

[Fdawgs]

Happy to mass update rest of the repos with a similar PR at some point this weekend, unless @gurgunday beats me to it 😂

[Uzlopak]

What about prefixing npm packages with npm:? Wouldnt we then be deno compatible?

[gurgunday]

Happy to mass update rest of the repos with a similar PR at some point this weekend, unless @gurgunday beats me to it 😂

🤣, I just wanted to get the ones I actively use out of the way in case there is a release or something

I would of course prefer if you created a script for it 😁

[Fdawgs]

What about prefixing npm packages with npm:? Wouldnt we then be deno compatible?

Can't find anything in node's documentation about supporting this?

[Uzlopak]

LGTM

[Fdawgs]

@mcollina happy to update Pino repos accordingly also, wdyt?