Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove handlebars #464

Merged
merged 2 commits into from
Aug 22, 2024
Merged

chore: remove handlebars #464

merged 2 commits into from
Aug 22, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 21, 2024

Checklist

@jsumners
Copy link
Member

Is there a reason?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 21, 2024

@jsumners

the handlebars test does not make any sense, and is more like a handlebars test than a fastify-static test.

Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the test part but the example without a template engine is dangerous as if a file name contains " or a special HTML char, the template in this example would break

Even if it would be fine here, it's not a good practice to show it as an example I think

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 21, 2024

Maybe, but even we are not using handlebars in our implementation of fastifystatic

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsumners
jsumners approved these changes Aug 22, 2024
@Uzlopak Uzlopak merged commit 39e89ea into master Aug 22, 2024
13 checks passed
@Uzlopak Uzlopak deleted the remove-handlebars branch August 22, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants