fix: disable root path check when serve is false #466
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR addresses the issue where the
checkRootPathForErrors
function still requires a valid path to root even whenserve: false
is set.Changes
checkRootPathForErrors
whenserve: false
.serve: false
.Tests
test/static.js
to verify thatcheckRootPathForErrors
is not called whenserve: false
.This fix allows users to use the
sendFile
decorator without needing to serve static files, as requested.Checklist
npm run test
andnpm run benchmark
and the Code of conduct